Codecov Report

Attention: Patch coverage is 61.42857% with 27 lines in your changes missing coverage. Please review.

📢 Thoughts on this report? Let us know!

The agentops/common directory is currently being used as a shared space for various instrumentation-related functions and utilities. However, logging seems to function as a separate instrumentor in itself. I suggest moving log instrumentation to /agentops/logging cause we might move instrumentation out of agentops for better maintenance, It makes sense to manage and update instrumentation packages independently rather than bumping the sdk itself every time an instrumentation needs update.

The agentops/common directory is currently being used as a shared space for various instrumentation-related functions and utilities. However, logging seems to function as a separate instrumentor in itself. I suggest moving log instrumentation to /agentops/logging cause we might move instrumentation out of agentops for better maintenance, It makes sense to manage and update instrumentation packages independently rather than bumping the sdk itself every time an instrumentation needs update.

I totally understand this sentiment. We're instrumenting print and other loggers in this function so to me it felt like it belonged better in instrumentation, but I see what you're saying with instrumentation packages. i can move it :)